Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added resignMasternode RPC #419

Merged
merged 17 commits into from
Jun 28, 2021
Merged

Added resignMasternode RPC #419

merged 17 commits into from
Jun 28, 2021

Conversation

siradji
Copy link
Contributor

@siradji siradji commented Jun 23, 2021 •
edited
Loading

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Added resignMasternode rpc

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

@siradji siradji self-assigned this Jun 23, 2021
@codeclimate
Copy link

codeclimate bot commented Jun 23, 2021 •
edited
Loading

Code Climate has analyzed commit 0ae1da5 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 23, 2021 •
edited
Loading

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 7b811b3

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d5608c1ebb9e00078cb0f7

😎 Browse the preview: https://deploy-preview-419--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 23, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.85 KB (+0.12% 🔺) 417 ms (+0.12% 🔺) 163 ms (-11.94% 🔽) 580 ms

@codecov
Copy link

codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #419 (0ae1da5) into main (58fba5e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          95       95           
  Lines        2778     2780    +2     
  Branches      351      352    +1     
=======================================
+ Hits         2703     2705    +2     
  Misses         75       75
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/masternode.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fba5e...0ae1da5. Read the comment docs.

@canonbrother
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

resignMasternode RPC implementation #48

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

can you follow rpc pull request template as usual??

@siradji siradji marked this pull request as ready for review June 24, 2021 08:35
@siradji siradji requested a review from thedoublejay as a code owner June 24, 2021 08:35
@siradji
Copy link
Contributor Author

siradji commented Jun 24, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

resignMasternode RPC implementation #48

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

can you follow rpc pull request template as usual??

@canonbrother , it is done.

@siradji siradji requested a review from jingyi2811 June 24, 2021 11:32
canonbrother
canonbrother previously requested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those client.... rpcs should not be covered in this test, replace it using container.call

@fuxingloh fuxingloh mentioned this pull request Jun 25, 2021
Open
@siradji siradji requested a review from jingyi2811 June 27, 2021 22:42
@fuxingloh fuxingloh enabled auto-merge (squash) June 28, 2021 07:20
@fuxingloh fuxingloh merged commit 2597122 into main Jun 28, 2021
@fuxingloh fuxingloh deleted the siradji/rpc_resignmasternode branch June 28, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyi2811 jingyi2811 jingyi2811 approved these changes

@fuxingloh fuxingloh fuxingloh approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

Assignees

@siradji siradji

Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siradji @canonbrother @fuxingloh @jingyi2811 @defichain-bot